search

jscs-dev / node-jscs

:arrow_heading_up: JavaScript Code Style checker (unmaintained)
https://jscs-dev.github.io
MIT License
4.97k stars 515 forks source link

jscsignore #2203

Closed denim2x closed 8 years ago

denim2x commented 8 years ago

'isFileExcluded()' now delegates to Gitkeeper (a proper .gitignore processor); fixes #73

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.06%) to 96.089% when pulling 2c3ec9fde84628025329aafe0d6a3a2ed1f9815f on denim2x:jscsignore into 99bdf4f7240110a30ff223fcebcca4868bcdb4e3 on jscs-dev:master.

indexzero commented 8 years ago

This looks like a great start. Could you:

  1. Provide some more details about the changes to the internals for the jscs core team?
  2. How does this get exposed through the jscs CLI?
  3. Documentation updates.
  4. Would like to see some more test coverage for edge cases in the ignore files.
qfox commented 8 years ago

First of all, you've made a great start and thank you for contribution!

Would like to see some more test coverage for edge cases in the ignore files.

Would be great to have specs in GitKeeper module ;-) We don't need to test it here again.

Would you mind to make it there?

How does this get exposed through the jscs CLI?

Good catch. I don't get it atm. Don't even mind how it could be.

I'd say, on this basis we could FINALLY finish epic #73 ;-)