search

jscs-dev / node-jscs

:arrow_heading_up: JavaScript Code Style checker (unmaintained)
https://jscs-dev.github.io
MIT License
4.97k stars 515 forks source link

Preset: allow URLs inside comments in airbnb.json #2207

Closed andreyvolokitin closed 8 years ago

andreyvolokitin commented 8 years ago

Make an exception for URLs inside comments in maximumLineLength rule

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 96.151% when pulling ef9098bbbec3861a929b2f850e53f918018e31d7 on andreyvolokitin:patch-1 into 99bdf4f7240110a30ff223fcebcca4868bcdb4e3 on jscs-dev:master.

markelog commented 8 years ago

Don't see this in their code style, sorry

andreyvolokitin commented 8 years ago

They have it in their ESLint config, see https://github.com/airbnb/javascript/issues/819

markelog commented 8 years ago

Fair enough

markelog commented 8 years ago

Landed! And thank you for the persistence.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.4%) to 95.704% when pulling ef9098bbbec3861a929b2f850e53f918018e31d7 on andreyvolokitin:patch-1 into 99bdf4f7240110a30ff223fcebcca4868bcdb4e3 on jscs-dev:master.