search

jscs-dev / node-jscs

:arrow_heading_up: JavaScript Code Style checker (unmaintained)
https://jscs-dev.github.io
MIT License
4.96k stars 513 forks source link

breaking change in v3 with disallowQuotedKeysInObjects #2213

Closed ljharb closed 8 years ago

ljharb commented 8 years ago

The changelog doesn't mention it, but disallowQuotedKeysInObjects no longer accepts "allButReserved".

elicwhite commented 8 years ago

I'm also getting an error on requireCamelCaseOrUpperCaseIdentifiers when upgrading from 2.11. It apparently no longer accepts ignoreProperties

requireCamelCaseOrUpperCaseIdentifiers option requires a true value or Object`
hzoo commented 8 years ago

@ljharb right now it's disallowQuotedKeysInObjects: { allExcept: ['reserved'] }

@TheSavior right now it's an object with the ignoreProperties property. requireCamelCaseOrUpperCaseIdentifiers: {ignoreProperties: true}

Sorry, yeah we need to add these to the changelog

ljharb commented 8 years ago

@hzoo yes but disallowQuotedKeysInObjects: "allButReserved" worked in v2, thus it's an undocumented breaking change - the issue is just for the changelog.

hzoo commented 8 years ago

Yeah I know, just didn't get to finish it up in time for the release (was my intention to add all that in). And what do you know I just remembered I already did that work https://github.com/jscs-dev/node-jscs/pull/2110#issue-130002352.

I think maybe we should just revert that at this point so upgrading shouldn't need any changes at all. https://github.com/jscs-dev/node-jscs/pull/2217

hzoo commented 8 years ago

Ok reverting that https://github.com/jscs-dev/node-jscs/pull/2217 and will release 3.0.2 soon