search

jscs-dev / node-jscs

:arrow_heading_up: JavaScript Code Style checker (unmaintained)
https://jscs-dev.github.io
MIT License
4.97k stars 515 forks source link

Breaking change from 2.11 to 3.0.2, unsupported rule esnext #2220

Closed TheSavior closed 8 years ago

TheSavior commented 8 years ago

When bumping jscs to 3.0.2, I get this error.

validateQuoteMarks: Unsupported rule: esnext at src/index.js :
     1 |'use strict';

My config looks like this:

{
  "plugins": ["wealthfront-javascript"],
  "preset": "wealthfront-javascript",
  "esnext": true
}

From the changelog it sounds like the goal was to make there be no breaking changes like this. It sounds like the configuration option was removed and I should remove it from my config.

hzoo commented 8 years ago

Thanks for reporting. I updated the changelog to clarify. We removed options that we going to be on by default.

I already reverted the rule deprecations in https://github.com/jscs-dev/node-jscs/commit/baede85f7f09de98dae22bf1b7b8b8e25fa3c0b2 which would of caused other config changes.

I also have a PR open (not done) to add a message about those specifically https://github.com/jscs-dev/node-jscs/pull/2208. Or we should just ignore them and leave it on by default

TheSavior commented 8 years ago

It looks like the change made the error show up sooner, but it isn't a warning, it actually causes a build failure. 

Config values to remove in 3.0:
The `esnext` option is enabled by default.

https://travis-ci.org/TheSavior/clean-git-ref/jobs/123588553

hzoo commented 8 years ago

Ah yeah I threw an error.

It wasn't warning before either but we could change it to a warning instead good point.. might have to refactor the rule logic since it was erroring multiple times