Revert "Configuration: exclude nested node_modules by default"

jscs-dev / node-jscs

:arrow_heading_up: JavaScript Code Style checker (unmaintained)

https://jscs-dev.github.io

MIT License

4.97k stars 515 forks source link

Revert "Configuration: exclude nested node_modules by default" #2222

Closed hzoo closed 8 years ago

hzoo commented 8 years ago

This reverts commit 908bd20654723eac98949f994710c9ea902fe671.

Fixes https://github.com/jscs-dev/node-jscs/issues/2221

Either we revert back to the old behavior and only exclude the top node_modules by default (which is what eslint is doing) or we also exclude nested ones by default.

hzoo commented 8 years ago

@kirbysayshi Ok I think we are going to revert to previous behavior in 2.x and users will have to specify nested node_modules themselves since that isn't as common of a use case.

coveralls commented 8 years ago

Coverage remained the same at 96.777% when pulling 675f9f2e727a61893f1dfadd5b671b5109817933 on revert-nested-node-modules into 9ce1c9bd58d9a860b4d49ea8bba7b794ba7a75ab on master.