Misc: do not modify CST in check mode

jscs-dev / node-jscs

:arrow_heading_up: JavaScript Code Style checker (unmaintained)

https://jscs-dev.github.io

MIT License

4.97k stars 515 forks source link

Misc: do not modify CST in check mode #2252

Closed markelog closed 8 years ago

markelog commented 8 years ago

Slightly changes token-assert API by providing result of the check with return values
Apply fixes only in fix mode
Modify couple rules to adjust to new strategy
Make "fixed" property of the Error instance consistent
Introduce "fix" property of the Error class
Divide fix behaviour on "common" and "specific" actions

Consequently should speed up linting

Fixes #2250

/cc @mdevils

coveralls commented 8 years ago

Coverage decreased (-0.03%) to 96.747% when pulling cbf974c5ada76da254160b217d66490009731861 on markelog:2250 into 9eaa1f7c619a356b4d887c60760d2eb36543a59f on jscs-dev:master.

markelog commented 8 years ago

Coverage decreased (-0.03%)

I think we can live with that in maintenance mode