Errors in JSX files return incorrect column numbers

jscs-dev / node-jscs

:arrow_heading_up: JavaScript Code Style checker (unmaintained)

https://jscs-dev.github.io

MIT License

4.97k stars 515 forks source link

Errors in JSX files return incorrect column numbers #2261

Closed crucialfelix closed 8 years ago

crucialfelix commented 8 years ago

The column numbers are incorrect when reporting errors in jsx files.

See https://github.com/AtomLinter/linter-jscs/issues/259

jscs 3.0.3

@Arcanemagus isolated a very simple reproducer: https://github.com/AtomLinter/linter-jscs/files/291711/linter-jscs_GH259.zip

Note that on the last error it's pointing well past the end of the line, and the error before that is pointing to the entirely wrong place (but isn't triggering this warning since it is still within the confines of the line).

markelog commented 8 years ago

At this point only major and CST related bugs will be fixed.

crucialfelix commented 8 years ago

Fair enough. Looking forward to the new eslint. Jscs has been very helpful. Thanks !