jscs-dev / node-jscs

:arrow_heading_up: JavaScript Code Style checker (unmaintained)
https://jscs-dev.github.io
MIT License
4.97k stars 515 forks source link

file extension fixes. Fixes #2275 #2273 #2276

Closed graingert closed 8 years ago

graingert commented 8 years ago

Fixes #2275 #2273

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.02%) to 96.713% when pulling c3f051edb295c0d49d040fed81a52f5f588a3a6e on graingert:prevent-defaults-overriding-config into 5885239955167317593c0896420651c46114b135 on jscs-dev:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.02%) to 96.713% when pulling 1da372ca8c1372eef888a837cb57cd077bbf3796 on graingert:prevent-defaults-overriding-config into 5885239955167317593c0896420651c46114b135 on jscs-dev:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.003%) to 96.733% when pulling 72a2aec092a72c198858b972f397ad6a3c351fbe on graingert:prevent-defaults-overriding-config into 5885239955167317593c0896420651c46114b135 on jscs-dev:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.003%) to 96.733% when pulling 72a2aec092a72c198858b972f397ad6a3c351fbe on graingert:prevent-defaults-overriding-config into 5885239955167317593c0896420651c46114b135 on jscs-dev:master.

markelog commented 8 years ago

Decided to fix this a bit differently, would appreciate a second look though - https://github.com/jscs-dev/node-jscs/commit/0d027a7b4a95c7c349f57ffd37f10e497d66a5d4

graingert commented 8 years ago

@markelog this doesn't fix #2273

markelog commented 8 years ago

It's not supposed to

graingert commented 8 years ago

Can you reopen #2273 so I can recreate the PR to fix it? On 21 Jun 2016 9:18 pm, "Oleg Gaidarenko" notifications@github.com wrote:

It's not supposed to

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jscs-dev/node-jscs/pull/2276#issuecomment-227558703, or mute the thread https://github.com/notifications/unsubscribe/AAZQTCeZNE9t6IyTqursHEg1WQnxRjMrks5qOEb0gaJpZM4I5kA1 .

markelog commented 8 years ago

I don't know man, everywhere i looked, like https://en.wikipedia.org/wiki/File_format#Filename_extension, https://en.wikipedia.org/wiki/Filename_extension https://docs.python.org/2/library/os.path.html#os.path.splitext, path.extname of node.js, http://ruby-doc.org/core-2.2.0/File.html#method-c-extname, https://golang.org/pkg/path/filepath/#Ext and others... give me the same result

markelog commented 8 years ago

You can probably workaround it with something like this though -

"excludeFiles": ["**/!(*.es2015.js)"]
graingert commented 8 years ago

@markelog nope, that seems to exlude all files.

markelog commented 8 years ago

It should ignore all files which ends with .es2015.js

graingert commented 8 years ago

@markelog I know. But it seems to exclude all files

markelog commented 8 years ago

Oh shoot, typo there, it shouldn't ignore files which ends with .es2015.js

graingert commented 8 years ago

Sorry I doubled the mistake and thought that's what you said originally. It still ignores all files

markelog commented 8 years ago

Weird, works for me

markelog commented 8 years ago

Maybe you could illustrate it with test repo?

graingert commented 8 years ago

Yeah will do On 28 Jun 2016 9:25 pm, "Oleg Gaidarenko" notifications@github.com wrote:

Maybe you could illustrate it with test repo?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jscs-dev/node-jscs/pull/2276#issuecomment-229171838, or mute the thread https://github.com/notifications/unsubscribe/AAZQTKtKVU7youjy8hV-pMdOROWO0-5-ks5qQYNMgaJpZM4I5kA1 .