Closed graingert closed 8 years ago
Decided to fix this a bit differently, would appreciate a second look though - https://github.com/jscs-dev/node-jscs/commit/0d027a7b4a95c7c349f57ffd37f10e497d66a5d4
@markelog this doesn't fix #2273
It's not supposed to
Can you reopen #2273 so I can recreate the PR to fix it? On 21 Jun 2016 9:18 pm, "Oleg Gaidarenko" notifications@github.com wrote:
It's not supposed to
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jscs-dev/node-jscs/pull/2276#issuecomment-227558703, or mute the thread https://github.com/notifications/unsubscribe/AAZQTCeZNE9t6IyTqursHEg1WQnxRjMrks5qOEb0gaJpZM4I5kA1 .
I don't know man, everywhere i looked, like https://en.wikipedia.org/wiki/File_format#Filename_extension, https://en.wikipedia.org/wiki/Filename_extension https://docs.python.org/2/library/os.path.html#os.path.splitext,
path.extname
of node.js,
http://ruby-doc.org/core-2.2.0/File.html#method-c-extname,
https://golang.org/pkg/path/filepath/#Ext
and others... give me the same result
You can probably workaround it with something like this though -
"excludeFiles": ["**/!(*.es2015.js)"]
@markelog nope, that seems to exlude all files.
It should ignore all files which ends with .es2015.js
@markelog I know. But it seems to exclude all files
Oh shoot, typo there, it shouldn't ignore files which ends with .es2015.js
Sorry I doubled the mistake and thought that's what you said originally. It still ignores all files
Weird, works for me
Maybe you could illustrate it with test repo?
Yeah will do On 28 Jun 2016 9:25 pm, "Oleg Gaidarenko" notifications@github.com wrote:
Maybe you could illustrate it with test repo?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jscs-dev/node-jscs/pull/2276#issuecomment-229171838, or mute the thread https://github.com/notifications/unsubscribe/AAZQTKtKVU7youjy8hV-pMdOROWO0-5-ks5qQYNMgaJpZM4I5kA1 .
Fixes #2275 #2273