search

jscutlery / nx-completion

Nx workspace completion plugin for Zsh.
MIT License
135 stars 14 forks source link

Format arguments to camel-case #4

Closed edbzn closed 3 years ago

edbzn commented 3 years ago

All arguments should be formatted in camel-case, eg: --i18nLocale instead of --i18n-locale.

amoghrajesh commented 3 years ago

@edbzn I would like to work on this issue. Let me know how I can onboard myself and how I can contribute. I would like to know how to test it etc too

edbzn commented 3 years ago

Hi @amoghrajesh, you can clone the repository, make the changes, source the code you have changed: source /<path-to-the-plugin>/nx-completion.plugin.zsh and try to type nx in the console to see the completion. Then push your changes and open a PR!

amoghrajesh commented 3 years ago

@edbzn could you assign this issue to me so I can work with you on this to solve this one?

amoghrajesh commented 3 years ago

@edbzn I need some more background / context to operate on this issue. Could you let me know how I can onboard to understand it?

edbzn commented 3 years ago

@amoghrajesh All arguments are formatted in kebab-case actualy, for example: 

        "--browser-target[Target to extract from.]:target:" \
        "--i18n-format[Format of the localization file specified with --i18n-file.]:format:" \

The best would be camel-case instead, I would expect something like: 

        "--browserTarget[Target to extract from.]:target:" \
        "--i18nFormat[Format of the localization file specified with --i18nFile.]:format:" \

etc... the list is quite long.

Alireza-Sampour commented 3 years ago

If the issue is still there I would like to work on this.

edbzn commented 3 years ago

@Alireza-Sampour go ahead!

Alireza-Sampour commented 3 years ago

I created a pull request, let me know if anything is forgotten.

edbzn commented 3 years ago

@Alireza-Sampour Thanks for the work!