Migrate to Laravel 5.7

[belguinan]

It would be good if we migrate to Latest version of Laravel. It's not required but we will have many features added, The only package that don't support 5.7 is shopping cart.

[jsdecena]

@belguinan and that is the core of this app right? :) There is already an issue created for the package so we just wait it out

[belguinan]

@jsdecena I am afraid if something went wrong with the developer or just on vacation for some "months", You can just fork it and update composer.json?

[jsdecena]

@belguinan Upgraded to L5.7 See commit https://github.com/Laracommerce/laracom/commit/7ec40a5df2a4e748d483611bfbde96998e08fc3f

[belguinan]

@belguinan Upgraded to L5.7 See commit 7ec40a5

@jsdecena I think we need to refactor the code, routes... We can use dependency injection instead of getting new item by id on database. What do you think? Why we need repositories instead of the default tools provided?

[jsdecena]

@belguinan Refactor which one?

[belguinan]

@jsdecena Routes CRUD. instead of calling find product by id for exemple we can just typehint Product on controller

[jsdecena]

That is done because development starts with tests (TDD). We need to create reusable methods and test it if it works. So every time we use it we know that the method we create is always working.

[belguinan]

@jsdecena I understand