search

jsdecena / laracom

Laravel FREE E-Commerce Software
https://jsdecena.github.io/laracom
1.91k stars 861 forks source link

Namespace bugs #260

Closed dev-ishantripathi closed 3 years ago

dev-ishantripathi commented 3 years ago

There seem to be a couple of namespace issues when opening admin dashboard links. One of the screenshots is attached below. I am attaching one of such case as I explore more I see it a lot of places. Such as LoginRequest Class

image

jsdecena commented 3 years ago

Any replication steps? @dev-ishantripathi

viktormaar commented 3 years ago

I append my issue here, looks related. Also noticed some namespace bugs with a newly installed one. Version 1.6.2 PHP 7.3 Steps to reproduce: 1) Install Laracom according the documentation 2) Migrate & seed 3) Go to /admin and perform a login 4) Whoops error:

ReflectionException Class App\Shop\Admins\Requests\LoginRequest does not exist

A hotfix is to search for App\Shop\Admins in the whole project and replace all instances to App\Shop\Employees. It will solve at least the admin login issue. BTW I am planning to make a PR for this anyways.

viktormaar commented 3 years ago

PR added: https://github.com/jsdecena/laracom/pull/262 I could not reproduce issue from @dev-ishantripathi. CourierRepository namespacing looks good, admin functions works.