search

jsdecena / laracom

Laravel FREE E-Commerce Software
https://jsdecena.github.io/laracom
1.91k stars 861 forks source link

Fixes #260 2nd part #263

Closed viktormaar closed 3 years ago

viktormaar commented 3 years ago

Simply running a unit test I discovered the issues mentioned by @dev-ishantripathi in https://github.com/jsdecena/laracom/issues/260 Both category requests, and also the country request had wrong namespacing. This PR fixes that.

(Sorry for pushing in separate PR:s)

codecov[bot] commented 3 years ago

Codecov Report

Merging #263 (65f7b68) into master (f9551a3) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #263   +/-   ##
=========================================
  Coverage     79.95%   79.95%           
  Complexity      606      606           
=========================================
  Files           129      129           
  Lines          2135     2135           
=========================================
  Hits           1707     1707           
  Misses          428      428
Impacted Files Coverage Δ
...ontrollers/Admin/Categories/CategoryController.php 100.00% <ø> (ø)
...dmin/Categories/Requests/CreateCategoryRequest.php 100.00% <ø> (ø)
...dmin/Categories/Requests/UpdateCategoryRequest.php 100.00% <ø> (ø)
.../Controllers/Admin/Countries/CountryController.php 100.00% <ø> (ø)
.../Admin/Countries/Requests/UpdateCountryRequest.php 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f9551a3...65f7b68. Read the comment docs.