jsdecena / laracom

Laravel FREE E-Commerce Software
https://jsdecena.github.io/laracom
1.91k stars 861 forks source link

Categories / Image remove not working #278

Closed flimbo closed 2 years ago

flimbo commented 2 years ago

function in CategoryRepository.php

public function deleteFile(array $file, $disk = null) : bool { return $this->update(['cover' => null]); }

seems that parameter $file is not passed anywhere. Plus it looks like function is only updating table and does not provide any real delete file from filesystem.

jsdecena commented 2 years ago

@flimbo See https://github.com/jsdecena/laracom/commit/d90ac92cee9eaf7d715d9c11a4a2c92f6acb3feb