search

jsdecena / laracom

Laravel FREE E-Commerce Software
https://jsdecena.github.io/laracom
1.91k stars 861 forks source link

Fix: can't update order status #287

Closed ysknsid25 closed 2 years ago

ysknsid25 commented 2 years ago

On the Edit Order Status screen, an error occurred when pressing the Update button without changing any values. The cause was the uniqueness of UpdateOrderStatusRequest. The uniqueness check should have been performed on records other than the ID of the update target, but the uniqueness check was performed on the update target itself. After the fix, I am running OrderStatusUnitTest.php. The test on the screen is fine.

jsdecena commented 2 years ago

@k-yamasaki-zakisan where is your Dockerfile for apple M1?

ysknsid25 commented 2 years ago

@k-yamasaki-zakisan

Is your twitter account perhaps https://twitter.com/k_yamasaki_zaki ? We would love to follow you if you like.

k-yamasaki-zakisan commented 2 years ago

Hi @jsdecena !

Sorry I don't have this project's Dockerfile for apple M1. Because I used Intel Mac when I contributed to this project. (PR)

Why did you send me the mention?

Thank you!

k-yamasaki-zakisan commented 2 years ago

@ysknsid25

Is your twitter account perhaps https://twitter.com/k_yamasaki_zaki ?

That's right. I'm amazed you found my twitter account😳

We would love to follow you if you like.

sure, great !!