#Fix Cover image is not displayed on the top page

[ysknsid25]

Occurring event

Register a Cover image in the admin panel.

Check on the top page

Cover image is not displayed.

Direct cause

The path of the Cover image on the top page is not correct.

Wrong(before fix)

Correct(before fix)

Temporary rewrite of path from "validation" showed up correctly

Root cause

Not using function transformProduct of trait ProductTransformable.

For example, the Cover image on the admin page is displayed correctly because using function transformProduct.

Corrective actions

Set the products acquired in HomeController to the correct paths by using the function transformProduct of therait ProductTransformable, and set them to the variables cat1 and cat2.

This caused the image to appear correctly on the Top page.

[jsdecena]

this is good @ysknsid25 but the test is failing

[ysknsid25]

this is good @ysknsid25 but the test is failing

Our sincere apologies. We will contact you after rechecking.

[ysknsid25]

@jsdecena

Sorry, it is succeeding locally but failing on Github Actions. I will look into it some more.

[ysknsid25]

@jsdecena

The cause of test code failure is the presence of apostrophes in the generated test data.

The location where the GithubAcions error occurs is different each time.

1. Tests\Feature\Admin\Brands\BrandFeatureTest::it_can_list_all_the_brands

2.Tests\Feature\Admin\Courier\CourierFeatureTest::it_can_list_all_couriers

Both test cases verify the same process.

That is the process of whether the value of the name column of the registered data is displayed on the screen.

However, in both error patterns, the apostrophe is displayed as ＆＃０３９； due to the HTML encoding process.

In conclusion, we believe that these test codes are inappropriate because the test codes may throw errors if the generated test data happen to contain apostrophes.

We will make additional modifications to the test codes that correct this condition.

[jsdecena]

I see what you mean, all good! I will fix it up later myself. :)

[ysknsid25]

@jsdecena

Thanks for fixing the test code! We will look at how it was modified at a later date.