search

jsdelivr / bot

DEPRECATED The jerk of a bot that checks PRs and responds in comments
22 stars 14 forks source link

Long forgotten main files #32

Open jimaek opened 9 years ago

jimaek commented 9 years ago

What can we do to make these errors disappear https://github.com/jsdelivr/jsdelivr/pull/3601 ? We created a custom mainfile a long time ago so there is no point showing these errors for ever

megawac commented 9 years ago

We could add a field to the info.ini?

jimaek commented 9 years ago

What kind of field? I guess we need to add .mainfile to the API for this feature to work?

megawac commented 9 years ago

Maybe something like

checkMainFiles: > 1.2

On Mon, Apr 6, 2015 at 1:58 PM, Dmitriy Akulov notifications@github.com wrote:

What kind of field? I guess we need to add .mainfile to the API for this feature to work?

— Reply to this email directly or view it on GitHub https://github.com/jsdelivr/bot/issues/32#issuecomment-90176258.

jimaek commented 9 years ago

Nah, too much work to maintain. I think we need to add it to the API, then your bot could simply parse it and only throw errors when there is no mainfile override file. What do you think?

jimaek commented 9 years ago

@megawac Our API now supports this http://api.jsdelivr.com/v1/jsdelivr/libraries?name=imagesloaded Each version has its own mainfile parameter as well.

megawac commented 9 years ago

The main difficulty (besides finding time) is supporting both .mainfile (#10) and this. For instance if the user changes the mainfile (https://github.com/jsdelivr/jsdelivr/pull/5927), its difficult to determine if that affects a folder with a .mainfile. One possible workaround would be to have the API include a flag for each version if a .mainfile is set

jimaek commented 9 years ago

@megawac Can we include this feature into v2? Can you make sure we dont forget this?

megawac commented 9 years ago

This can also be added to v1. Either way, it should be a simple fix

On Fri, Jul 17, 2015 at 4:16 AM, Dmitriy Akulov notifications@github.com wrote:

@megawac https://github.com/megawac Can we include this feature into v2? Can you make sure we dont forget this?

— Reply to this email directly or view it on GitHub https://github.com/jsdelivr/bot/issues/32#issuecomment-122212807.

jimaek commented 9 years ago

Lets add it only to v2, there has to be motivation to switch to v2.