search

jsdelivr / bot

DEPRECATED The jerk of a bot that checks PRs and responds in comments
22 stars 14 forks source link

JSON incorrectly passing #40

Closed jimaek closed 9 years ago

jimaek commented 9 years ago

The bot considers this as correct

{
  "packageManager": "github",
  "name": "jdenticon",
  "repo": "dmester/jdenticon",
  "files": {
    "basePath": "dist/",
    "exclude": "jdenticon.js"
  }
}

while its not and libgrabber will fail. The correct is "exclude": ["file"]

megawac commented 9 years ago

Want to make a spec of things you want validated in regards to the update.json file?

On Mon, May 4, 2015 at 1:20 PM, Dmitriy Akulov notifications@github.com wrote:

Assigned #40 https://github.com/jsdelivr/bot/issues/40 to @megawac https://github.com/megawac.

— Reply to this email directly or view it on GitHub https://github.com/jsdelivr/bot/issues/40#event-296452792.

jimaek commented 9 years ago

exclude and include are arrays, so the bot will fail to update the project in its current form