search

jsdelivr / globalping-cli

A simple CLI tool to run networking commands remotely from hundreds of globally distributed servers
Mozilla Public License 2.0
129 stars 14 forks source link

Ensure all our guidelines are followed #33

Closed MartinKolarik closed 1 year ago

MartinKolarik commented 1 year ago

https://github.com/jsdelivr/globalping/blob/master/docs/CLIENT_GUIDELINES.md

didil commented 1 year ago

@MartinKolarik the document mentions

If the status is in-progress, wait 1 second

At the moment in the CLI, we're only waiting 100 milliseconds, should I change that to 1 second ?

MartinKolarik commented 1 year ago

Yes, let's change that.

jimaek commented 1 year ago

Before changing please test locally different values in between. If there's no difference then set 1s but if a lower value results in a better user experience then let's consider that