Install probe command - Githubissues

jsdelivr / globalping-cli

A simple CLI tool to run networking commands remotely from hundreds of globally distributed servers

Mozilla Public License 2.0

129 stars 14 forks source link

Install probe command #52

Closed didil closed 1 year ago

didil commented 1 year ago

Fixes #5

added install-probe command
- checks if docker is installed locally
- checks if the globalping-probe container already exists
- asks for user permission to install and run the globalping-probe container
- installs and runs the globalping-probe container
tested in Macos / Docker For Mac
tested in Debian GNU/Linux 11 / docker.io
tested in Windows 10 Pro / Docker For Windows
podman not supported yet (created separate issue #51)

jimaek commented 1 year ago

I updated some texts, let me know what you think

jimaek commented 1 year ago

Btw I think when a CLI shows this [Y/n] its assumed that if you press enter without input it will default to yes due to the capital letter. In our case its not

didil commented 1 year ago

I updated some texts, let me know what you think

looks good to me thanks !

didil commented 1 year ago

Btw I think when a CLI shows this [Y/n] its assumed that if you press enter without input it will default to yes due to the capital letter. In our case its not

ok just pushed an update to accept new line as a confirmation