jsdelivr / globalping-cli

A simple CLI tool to run networking commands remotely from hundreds of globally distributed servers
Mozilla Public License 2.0
129 stars 14 forks source link

Fix Liveview overflow #67

Closed didil closed 1 year ago

didil commented 1 year ago

Fixes #60 improves output trimming for liveview by handling tabs / unicode chars

jimaek commented 1 year ago

Can you please clarify if this fixes the full issue or not? Because the comment by the library maintainer mentioned that there is nothing we can do if the output is larger than the terminal?

didil commented 1 year ago

@jimaek this PR does not modify the logic that we have been using until now to display the content for the liveview:

What has been causing the issue we've been having with http https://www.jsdelivr.com --method GET is that the output contains "tab" characters that were not accounted for properly when truncating the output. This PR mostly fixes the handling of "tab" characters.