search

jsdelivr / globalping-cli

A simple CLI tool to run networking commands remotely from hundreds of globally distributed servers
Mozilla Public License 2.0
129 stars 14 forks source link

Faster liveview trimming #69

Closed didil closed 1 year ago

didil commented 1 year ago

Fixes #68 Use single call to runewidth.StringWidth to optimize performance

jimaek commented 1 year ago

Can you please run the same test as Martin to see the perf difference?

didil commented 1 year ago

Before the PR I get:

real    0m4.698s
user    0m3.435s
sys     0m0.239s

With this PR I get:

real    0m1.567s
user    0m0.330s
sys     0m0.233s
MartinKolarik commented 1 year ago

Performance seems to be back to normal 👍

didil commented 1 year ago

found a bug (crashes on chinese language website https://www.zhihu.com/signin due to the approximation). working on fixing it

didil commented 1 year ago