search

jsdelivr / globalping-hwprobe

OS image for Globalping hardware probes. Become a GitHub Sponsor to get yours!
19 stars 6 forks source link

Docker log spamming #43

Closed jimaek closed 5 months ago

jimaek commented 6 months ago

How is the current docker logging logic configured? What if the container decides to write 100TB of logs? There are options to limit that, e.g. https://docs.docker.com/config/containers/logging/local/ Are we using them?

kernelgurumeditation commented 6 months ago

@jimaek, no, we aren't; I will make the change... probably limit it to 10 M

Maybe it would be a good idea to have a specialized docker, one that is controlled and will not have crazy, unexpected changes.

jimaek commented 6 months ago

yeah lets limit to 10MB. I think it writes to a RAM mounted endpoint, right? So it wont touch the SD card either way.

specialized docker

Not sure what is that :)

kernelgurumeditation commented 6 months ago

Yep, all writes are done to RAM

Not sure what is that :)

Ops, I meant a container image :)

MartinKolarik commented 6 months ago

Maybe it would be a good idea to have a specialized docker, one that is controlled and will not have crazy, unexpected changes.

Yes, I thought about that as well, maybe in the future... But I guess the impact here is lower than I initially realized since when the RAM fills up, the device just restarts and works normally again, right?

kernelgurumeditation commented 6 months ago

But I guess the impact here is lower than I initially realized since when the RAM fills up, the device just restarts and works normally again, right?

Yep!

jimaek commented 6 months ago

So should we apply the logs limits? The devices have arrived and I'm ready to start flashing the new firmware before shipping

kernelgurumeditation commented 6 months ago

I made the change last week and left it running tests on my HW probe let me arrive home and check if everything is okay If it is okay, I will push an MR with the change in 2 or 3 hours.

MartinKolarik commented 6 months ago

So should we apply the logs limits? The devices have arrived and I'm ready to start flashing the new firmware before shipping

I'll still want to finish up the probe update before that so there is some time :)