jsdelivr / globalping

A global network of probes to run network tests like ping, traceroute and DNS resolve
https://globalping.io
255 stars 31 forks source link

Update region names #179

Closed MartinKolarik closed 2 years ago

MartinKolarik commented 2 years ago

Missed part of #162, "southern america" should be "South America"

patrykcieszkowski commented 2 years ago

Why particularily South, not Southern?

jimaek commented 2 years ago

That's the most popular name I think. But we can support both

patrykcieszkowski commented 2 years ago

we match the region name based on country-code, so technically speaking we can name them whatever we want.

MartinKolarik commented 2 years ago

Why particularily South, not Southern?

I think "South" is the correct version of the two but didn't actually change that on purpose, it must have been Grammarly fixing that for me.

ayuhito commented 2 years ago

I threw it in a couple gazetteers and there's a clear distinction between South America and Southern America (which is in North America).

They don't mix really.

patrykcieszkowski commented 2 years ago

I mean, South America is the continent, Southern America is more general, describing the region.

MartinKolarik commented 2 years ago

I mean, South America is the continent, Southern America is more general, describing the region.

Yes, but which region 😄 as @ayuhito points out, "Southern" is also used to refer to the South part of the US, which is an entirely different region.

patrykcieszkowski commented 2 years ago

hm, ok

MartinKolarik commented 2 years ago

But I'm not sure how the original list of regions was constructed. Specifically for South America, it seems there's no point in having it, since that's already a continent?

patrykcieszkowski commented 2 years ago

northern-europe, western-europe, eastern-europe etc aren't seperate continents, and yet it might be useful to have a filter targeting them.

https://github.com/jsdelivr/globalping/blob/master/src/lib/location/regions.ts

ayuhito commented 2 years ago

It feels a little arbitrary. What about matching Cloudflare if we want to have that much specificity? https://developers.cloudflare.com/load-balancing/reference/region-mapping-api/

Otherwise, we can have a broader set of regions matching the data center tab: https://www.cloudflare.com/network/

MartinKolarik commented 2 years ago

Sure, I'm not questioning regions as a whole, just Southern America specifically. E.g. https://en.wikipedia.org/wiki/Northern_America is a used term with a clear definition, but the Southern version isn't, and for South, there's already a continent.

patrykcieszkowski commented 2 years ago

It feels a little arbitrary. What about matching Cloudflare if we want to have that much specificity? https://developers.cloudflare.com/load-balancing/reference/region-mapping-api/

Otherwise, we can have a broader set of regions matching the data center tab: https://www.cloudflare.com/network/

Well, it is arbitrary. But I see no reason to rely on 3rd party API for such a simple mechanism.

patrykcieszkowski commented 2 years ago

Sure, I'm not questioning regions as a whole, just Southern America specifically. E.g. https://en.wikipedia.org/wiki/Northern_America is a used term with a clear definition, but the Southern version isn't, and for South, there's already a continent.

I'm out when it comes to geographical divagations. We can call it Latin America, South America, I really dont mind.

ayuhito commented 2 years ago

Well, it is arbitrary. But I see no reason to rely on 3rd party API for such a simple mechanism.

I didn't mean use their API. I meant match their regions and region codes since it seems like a solid option of choices that cover most usecases with correct names, in reference to their list.

MartinKolarik commented 2 years ago

For now, let's do the pretty names and normalization, then we can discuss the actual list of options.

patrykcieszkowski commented 2 years ago

in terms of filter matching, do we want dash or space seperation for exact matches?

MartinKolarik commented 2 years ago

As a user, I should write spaces, same as for cities (except magic mode).