jsdevkr / gitCodeShare.com

Contributhon 2018 - gitCodeShare.com (a.k.a gitShare)
https://gitcodeshare.com
MIT License
76 stars 21 forks source link

[Chrome-Extension] Facebook load UI asynchronously. #143

Closed ho1234c closed 6 years ago

ho1234c commented 6 years ago

We would like to insert button to facebook page. but I have observed that many UI in page use lazy loading. that is to say we can't know that when the UI will be load completely.

So what I thought was two ways to be sure when to insert.

  1. setInterval like #122
  2. add listener to click event that occur across pages. (It'll bubbling after all)

I don't think it's a good way either. let me know if you have any idea!

ho1234c commented 6 years ago

145

rayleighko commented 6 years ago

In addition, I think the cause of this problem is the same to this.

when the user clicks the write box (white box) and presses the '...' button, it works fine.

but, when the user presses the '...' button without pressing the write box, refreshed newsfeed.

This may be trivial, but you might think that it does not work properly because the user feels it. https://github.com/kosslab-kr/gitCodeShare.com/issues/147

gimdongwoo commented 6 years ago

You can use event listener.

example: 2018-10-08 9 54 11

gimdongwoo commented 6 years ago

And You can use query selector to find more button.

2018-10-08 9 58 21

use data-testid="ellipsis-sprout"

ho1234c commented 6 years ago

And You can use query selector to find more button.

2018-10-08 9 58 21

use data-testid="ellipsis-sprout"

I tried it. https://github.com/kosslab-kr/gitCodeShare.com/pull/154

but It is also not sure. word test smells fishy.