jsdevkr / gitCodeShare.com

Contributhon 2018 - gitCodeShare.com (a.k.a gitShare)
https://gitcodeshare.com
MIT License
76 stars 22 forks source link

[Suggestion] It seems dangerous that requests api for contributor in this way #221

Open currybob opened 5 years ago

currybob commented 5 years ago

Our contributor could change their name every moment. But, Like PR #219 , if contributors change their name, API not works properly, because Promise.all returns just reject if any of Promise array rejects result.

2018-11-02 7 42 01

So now we would decide the way it reflects

2018-11-02 9 16 04

I tried this way to avoid "fast-fail-behavior" in Promise.all and it works Please review it at #220 @gimdongwoo @thomasJang @aeei