Crypto library does not work once cache is used

jsdf / browserify-incremental

incremental rebuild for browserify

175 stars 13 forks source link

Crypto library does not work once cache is used #19

Closed stevenpetryk closed 8 years ago

stevenpetryk commented 9 years ago

Can be reproduced using this test repo I made. The error is Uncaught TypeError: Cannot read property 'version' of undefined, which is being thrown by the elliptic.js module of Browserify's crypto implementation. This only happens after the cache begins being used, which is incidentally after running browserify-incremental three times (see #8).

It's worth noting that the Watchify library has encountered the same problem (substack/watchify#130, indutny/elliptic#30).

stevenpetryk commented 9 years ago

The specific commit where the issue was fixed in watchify is Pleochism/watchify@e9fe543a8ff45b125273159dbd1477f2b9cc4759.

jreading commented 8 years ago

Same issue.

Macil commented 8 years ago

That linked commit was never merged into watchify. This is where it got fixed in watchify: https://github.com/substack/watchify/pull/160. It looks like browserify-incremental works like how watchify worked before that change.

jsdf commented 8 years ago

This should be fixed in v3.1.0