gabrielecirulli
commented
9 years ago I think I have a better inkling of what might be happening (still no idea how to solve it though):
I beautified the generated code and if you look at the part where the error I mentioned before happens, you see this:
{
// Rest of the bundle
"/myapp/vendor/assets/javascripts/modernizr.js": [function(require, module, exports) {;
__browserify_shim_require__ = require;
(function browserifyShim(module, exports, require, define, browserify_shim__define__module__export__) {
"use strict";
/* Modernizr 2.8.3 (Custom Build) | MIT & BSD
* Build: http://modernizr.com/download/#-svg-cssclasses-addtest-prefixed-teststyles-testprop-testallprops-hasevent-prefixes-domprefixes
*/
;
window.Modernizr = function(a, b, c) {
// Modernizr code
}(this, this.document);
;
browserify_shim__define__module__export__(typeof Modernizr != "undefined" ? Modernizr : window.Modernizr);
}).call(global, undefined, undefined, undefined, undefined, function defineExport(ex) {
module.exports = ex;
});
}, {}],
// Rest of the bundle
}The point where the error happens is that line near the bottom where you see }).call(global, undefined, undefined, undefined, undefined, function defineExport(ex) {. If you look closely, you'll notice that it calls the "shimming" function with global as this, yet global doesn't exist.
If you look near the top, in the line that goes "/myapp/vendor/assets/javascripts/modernizr.js": [function(require, module, exports) {;, that's where global should come into play: It should be passed to this file as one of the arguments;
Looking at the output of running browserify instead of browserify-inc, the signature of the same function looks like this: (function(process, global, Buffer, __argument0, __argument1, __argument2, __argument3, __filename, __dirname) {;. As you can see, that takes into account the requirement of global and it does pass it in as an argument. The whole thing works as a result.
This doesn't take me any closer to figuring out why global is not being passed in, but I thought I would ask you for help on this since you might have a better clue than me :smile:
jsdf
I have been trying to get browserify-incremental to work in browserify-rails by making it switch between the
browserifyandbrowserifyincbased on an option.With my current configuration, this command runs:
/myapp/node_modules/.bin/browserifyinc -d --extension=.jsx --fast --cachefile="/myapp/tmp/browserify-rails/browserifyinc-cache.json" -o "/myapp/tmp/browserify-rails/output20150106-13751-ay9tra" -Where
--extension=.jsxand--fastare added by my Rails application's config. The main JavaScript file comes from stdin, and the command is run in the correct directory so that all requires are tracked properly.This is the corresponding
browserifycommand, when the switch forbrowserifyincis disabled:/myapp/node_modules/.bin/browserify -d --extension=.jsx --fast -o "/myapp/tmp/browserify-rails/output20150106-14638-165eoyg" -Everything seems the same, however the output of
browserifyincfails with an error when it runs in my browser:The error seems weird, it comes from a part of the code that seems completely unrelated (I use modernizr with
browserify-shim).However, when inspecting the output of the two commands with a piece of code as simple as
console.log("Test"), I get radically different outputs:When run with
browserifyinc(the above command plus< testfile.js), I get:Running the above
browserifycommand, though, I get a radically different and longer output (it seems to contain Buffer, due to the--fastoption, but I suspect the differences don't stop there): Gist of both files.Lastly, the
browserifynode_module that is installed in my Rails app which browserify-rails uses is version6.3.4.browserify-incrementaldepends on^6.1.0, and going into itsnode_modulesI don't see abrowserifydirectory, so it seems to be relying on the same one the application itself uses if I'm not mistaken.Could you help me shed some light on this issue? I will be experimenting more options, but if you know anything I think it would help me a lot.
Although I tried removing the file and it didn't make any difference on
browserify's output, here are the contents of mypackage.json. The only thing that might have some bearing (since the error I mentioned above seems to have some correlation withbrowserify-shim) is the"browserify"key, which specifies6to5ifyandbrowserify-shimas transforms. Maybe they are not being picked up.