search

jsdf / pce

Emulates Mac Plus, PC, & Atari ST in the browser using WebAssembly
https://jamesfriend.com.au/pce-js
GNU General Public License v2.0
864 stars 154 forks source link

Support emsdk >= 1.38.26 #16

Closed DrJosh9000 closed 5 years ago

DrJosh9000 commented 5 years ago

Hi! I'm a massive fan of your work. Thanks so much for making Macintosh emulation in the browser happen.

I got the following errors in config.log when attempting to ./pcejs_build build macplus:

shared:ERROR: Invalid command line option -s BINARYEN_METHOD=native-wasm,asmjs: Starting from Emscripten 1.38.23, Emscripten now always builds either to Wasm (-s WASM=1 - default), or to asm.js (-s WASM=0), other methods are not supported (https:#github.com/emscripten-core/emscripten/pull/7836)

shared:ERROR: Invalid command line option -s PRECISE_I64_MATH=0: Starting from Emscripten 1.38.26, PRECISE_I64_MATH is always enabled (https:#github.com/emscripten-core/emscripten/pull/7935)

This patch makes it build, and I get some output in dist/, but I haven't checked if the output works.

jsdf commented 5 years ago

Hi Josh, I just got around to looking at this and noticed you closed it. What was the outcome here?

DrJosh9000 commented 5 years ago

I'm not sure what I was thinking when I closed it, whoops.