search

jsdom / cssstyle

A Node.js implementation of the CSS Object Model CSSStyleDeclaration interface
MIT License
109 stars 70 forks source link

Fix parsing of colors with decimal alpha #109

Closed kraynel closed 4 years ago

kraynel commented 4 years ago

Fix issue https://github.com/jsdom/jsdom/issues/2639. Color with decimal alpha values were not recognized.

codecov-io commented 4 years ago

Codecov Report

Merging #109 into master will increase coverage by 0.78%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   36.07%   36.86%   +0.78%     
==========================================
  Files          86       87       +1     
  Lines        1156     1172      +16     
  Branches      218      224       +6     
==========================================
+ Hits          417      432      +15     
- Misses        632      633       +1     
  Partials      107      107
Impacted Files Coverage Δ
lib/parsers.js 80.35% <100%> (-0.16%) :arrow_down:
lib/utils/colorSpace.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef0ed89...4f080c8. Read the comment docs.

jsakas commented 4 years ago

@kraynel thanks for the PR. Reviewed and it looks solid, thanks for including the tests!

domenic commented 4 years ago

@jsakas would you mind doing a release that includes this?

jsakas commented 4 years ago

@domenic will be publishing v2.1.0 this afternoon.