jsdom / cssstyle

A Node.js implementation of the CSS Object Model CSSStyleDeclaration interface
MIT License
109 stars 70 forks source link

fix: support auto as value for positioning props #123

Closed idanen closed 1 month ago

idanen commented 4 years ago

Fixes #122

codecov-io commented 4 years ago

Codecov Report

Merging #123 into master will increase coverage by 0.23%. The diff coverage is 35.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   37.39%   37.62%   +0.23%     
==========================================
  Files          87       87              
  Lines        1182     1188       +6     
  Branches      227      229       +2     
==========================================
+ Hits          442      447       +5     
- Misses        633      634       +1     
  Partials      107      107              
Impacted Files Coverage Δ
lib/properties/bottom.js 0.00% <0.00%> (ø)
lib/properties/left.js 0.00% <0.00%> (ø)
lib/properties/right.js 0.00% <0.00%> (ø)
lib/properties/top.js 0.00% <0.00%> (ø)
lib/parsers.js 80.68% <83.33%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b527ed7...7035224. Read the comment docs.

idanen commented 4 years ago

@tmpvar @jsakas , any chance someone can look into this anytime soon?

idanen commented 3 years ago

@domenic maybe? We really need this PR

idanen commented 3 years ago

@tmpvar @jsakas friendly reminder?

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 37.62%. Comparing base (b527ed7) to head (7035224). Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
lib/properties/bottom.js 0.00% 2 Missing :warning:
lib/properties/left.js 0.00% 2 Missing :warning:
lib/properties/right.js 0.00% 2 Missing :warning:
lib/properties/top.js 0.00% 2 Missing :warning:
lib/parsers.js 83.33% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #123 +/- ## ========================================== + Coverage 37.39% 37.62% +0.23% ========================================== Files 87 87 Lines 1182 1188 +6 Branches 227 229 +2 ========================================== + Hits 442 447 +5 - Misses 633 634 +1 Partials 107 107 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.