search

jsdom / cssstyle

A Node.js implementation of the CSS Object Model CSSStyleDeclaration interface
MIT License
107 stars 70 forks source link

fix: handle outline style/width #133

Closed cdoublev closed 2 years ago

cdoublev commented 3 years ago

Fix #2999.

codecov-commenter commented 3 years ago

Codecov Report

Merging #133 (153d3d7) into master (b527ed7) will decrease coverage by 0.65%. The diff coverage is 0.00%.

:exclamation: Current head 153d3d7 differs from pull request most recent head b1093ca. Consider uploading reports for the commit b1093ca to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   37.39%   36.74%   -0.66%     
==========================================
  Files          87       90       +3     
  Lines        1182     1203      +21     
  Branches      227      231       +4     
==========================================
  Hits          442      442              
- Misses        633      650      +17     
- Partials      107      111       +4
Impacted Files Coverage Δ
lib/properties/borderWidth.js 0.00% <0.00%> (ø)
lib/properties/outline.js 0.00% <0.00%> (ø)
lib/properties/outlineColor.js 0.00% <0.00%> (ø)
lib/properties/outlineStyle.js 0.00% <0.00%> (ø)
lib/properties/outlineWidth.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b527ed7...b1093ca. Read the comment docs.

cdoublev commented 2 years ago

Closing in favor of a full rewrite. See #140.