search

jsdom / cssstyle

A Node.js implementation of the CSS Object Model CSSStyleDeclaration interface
MIT License
107 stars 70 forks source link

Handle empty string and null for margin and padding subparts #165

Closed andrewiggins closed 8 months ago

andrewiggins commented 10 months ago

Per the linked issue in jsdom, the following bug exists, where dom is a JSDom instance:

const elem = dom.window.document.createElement('a');

elem.style.marginTop = '10px';
console.log(elem.style.marginTop); // '10px'

elem.style.marginTop = '';
console.log(elem.style.marginTop); // Expected '', but '10px' received.

This PR fixes this bug by specifying that null and empty string are valid values for subparts of the properties margin and padding. I've also added tests for the behavior of setting these properties to undefined (value should remain as is).

Verified that this behavior (using the repro above) matches the following browser's behavior:

Chrome 119.0.6045.123 Edge 120.0.2186.2 Firefox 120.0b8 Safari 17.1 (19616.2.9.11.7)

Fixes jsdom/jsdom#2504