jsdom / cssstyle

A Node.js implementation of the CSS Object Model CSSStyleDeclaration interface

MIT License

107 stars 70 forks source link

Add support for numeric values passed to ‘border-spacing’, e.g. ‘border-spacing: 0’. #47

Closed jansiegel closed 6 years ago

jansiegel commented 7 years ago

When providing 0 to border-spacing, cssstyle throws a v.toLowerCase is not a function error.

lsiu commented 6 years ago

We use jsdom for some testing and some libraries we test with has border-spacing set to 0. Can we merge this PR and publish a new release to npmjs? Thanks!

lsiu commented 6 years ago

I did another PR #52 which include a test and follow the same approach used in padding.js

sairoutine commented 6 years ago

+1 for merging this, got the same error on jsdom.

@chad3814

jansiegel commented 6 years ago

52 does basically the same thing as this one + adds tests, so I'm +1 for merging either one of those.