Check if usage of split fails in Unicode

jsdom / tr46

An implementation of the Unicode UTS #46: Unicode IDNA Compatibility Processing.

MIT License

32 stars 16 forks source link

Check if usage of split fails in Unicode #1

Closed Sebmaster closed 7 years ago

Sebmaster commented 9 years ago

Currently split is used to break apart the labels of the domain, however split might break apart at the wrong positions if a dot is position right after a surrogate character(?) maybe/probably.

TimothyGu commented 7 years ago

The only case where it may breaks is when the dot is between a leading and a trailing surrogate, which is an invalid state anyway. Hence I don't think this is an actual issue.

Sebmaster commented 7 years ago

Checked this recently. Not an issue. 👍