search

jsdom / tr46

An implementation of the Unicode UTS #46: Unicode IDNA Compatibility Processing.
MIT License
32 stars 14 forks source link

Add the ability to disable the hyphen check for labels #10

Closed Sebmaster closed 7 years ago

Sebmaster commented 7 years ago

So this is a weird one.

I think we previously had a bug with not fowarding the processing option to the label validation. However adding this causes about 100 more tests to fail.

I'm inclined to leave it since testing was never really useful anyways.

Also: We're currently not implementing the Bidi and ContextJ rules at all.

Sebmaster commented 7 years ago

Woops, thanks a lot. Fixed.

TimothyGu commented 7 years ago

This could be closed now.