search

jsdom / tr46

An implementation of the Unicode UTS #46: Unicode IDNA Compatibility Processing.
MIT License
32 stars 14 forks source link

Linting, upgrades, and cleanups #8

Closed domenic closed 7 years ago

domenic commented 7 years ago

On top of #7.

domenic commented 7 years ago

Hmm, the linting seems to have increased the number of failing tests from 488 to 504... maybe that bugfix wasn't so great after all. Investigating.

domenic commented 7 years ago

Well, yeah, reverting the bugfix by making it compare the processing function to PROCESSING_OPTIONS values (always false) decreases the failing tests back to 504... not sure what to do there.

Sebmaster commented 7 years ago

Did node v4 already support arrow functions? Might be a major?

domenic commented 7 years ago

Node v4 already supports arrow functions, yeah :) http://node.green/

Sebmaster commented 7 years ago

Let's get travis in here while we're at it?

domenic commented 7 years ago

Sure, although only you can flip the switch. Should we just not run tests, given the 500 failing ones?

Sebmaster commented 7 years ago

Yeah, that's alright with me. Can we get the linting and some basic syntax verification in there (by just running the index.js with node)?

domenic commented 7 years ago

Sure that makes sense.