search

jsdom / webidl2js

Auto-generate JS class structures for Web IDL specifications
MIT License
79 stars 30 forks source link

refactor: Rename imported symbols #179

Closed ExE-Boss closed 4 years ago

ExE-Boss commented 4 years ago

I’ve waited with opening this until after https://github.com/jsdom/webidl2js/pull/166 was done to avoid merge conflicts.

This frees up the impl variable for use in https://github.com/jsdom/webidl2js/pull/158 and also makes it clearer that the current impl variable refers to implSymbol.

TimothyGu commented 4 years ago

Rebased and fixed some issues that came up in rebasing (96794fa).

ExE-Boss commented 4 years ago

I had originally fixed that as part of https://github.com/jsdom/webidl2js/commit/42e8cd58691c203d62ac79b6a39dffd7ff86bac1.

TimothyGu commented 4 years ago

It’s possible that rebasing destroyed the merge. For future could you please rebase rather than merge