search

jsdrupal / drupal-admin-ui

This is an admin UI for Drupal, built with JavaScript & React. ⬅️✌️➡️
Other
238 stars 91 forks source link

implemented figma. added few widgets. #710

Closed iberdinsky-skilld closed 5 years ago

iberdinsky-skilld commented 5 years ago

Issue

https://github.com/jsdrupal/drupal-admin-ui/issues/705

Screenshot / UI changes

Added figma integration. As decorator

Image from Gyazo

Added few components figma integration. In all other existing components stories i wasn't sure about their designs location.

Testing instructions

Current implementation of storybook is broken, so this pr will work

ONLY

with that small fix

dawehner commented 5 years ago

Thank you for working on this! Note: We'll use the storybook in packages/components instead, as the previous version was mostly a prototype.

@iberdinsky-skilld I'm wondering whether @ckrina could split up the figma templates into a reference per component? This would make it nicer.

Current implementation of storybook is broken, so this pr will work

Could you add a PR for itself?

iberdinsky-skilld commented 5 years ago

@dawehner please recheck.

  1. I added same steps to components workspace. also added teststory to only one existing button component.

Image from Gyazo

  1. also it is wierd but i didn't have issues with building storybook in components workspace. so maybe

Could you add a PR for itself?

not required anymore?

  1. I think it is ok to have all modifiers in one page of figma. Storybook should display all of them aswell:

like here: https://danieldelcore.github.io/trousers/?path=/story/basic--elements-and-modifiers