search

jsdrupal / drupal-admin-ui

This is an admin UI for Drupal, built with JavaScript & React. ⬅️✌️➡️
Other
238 stars 91 forks source link

#733 react-scripts: update to 3.0.1 #734

Closed martinfrances107 closed 5 years ago

martinfrances107 commented 5 years ago

Issue

https://github.com/jsdrupal/drupal-admin-ui/issues/733

Screenshot / UI changes

Describe the UI changes / make a screenshot

Testing instructions

Please describe with a few words how to reproduce the problem / test the feature

I want to upgrade to the latest create-react-app

This means bumping the package versions of

react-scripts eslint

martinfrances107 commented 5 years ago

Thanks for looking at this

Ah the test would not pass unless changes to the prop types were made

Like a game of dominoes

changing the react-scripts triggered a change in linter. etc etc.

Maybe the changes to default settings ... could have been done in a separate issue.

dawehner commented 5 years ago

I totally get this. The changes of the proptypes you can though still do in a separate PR and make it a dependency of some other one.

martinfrances107 commented 5 years ago

Ah I see what you mean ... I should have spawned 3ish child issues...I will adjust my approach in future.

dawehner commented 5 years ago

Thank you Martin.

I always try to assume that the person reviewing has minimal time, so I try to make their life easier. I make mistakes all the time, but it's a good thing to keep in mind.

On Fri, 17 May 2019, 16:00 martin frances, notifications@github.com wrote:

Ah I see what you mean ... I should have spawned 3ish child issues...I will adjust my approach in future.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/jsdrupal/drupal-admin-ui/pull/734?email_source=notifications&email_token=AAAHH3QVSGNCG63KGY33UEDPV23ANA5CNFSM4HMSC5TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVU2VYQ#issuecomment-493464290, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAHH3RYGMDDYQ66M4AEV3TPV23ANANCNFSM4HMSC5TA .