Closed martinfrances107 closed 5 years ago
There is a error hidden in the README.md
looking at the "testing" subheading
the container name is incorrect throughout the command line instructions.
looking at a recent test run
https://circleci.com/gh/jsdrupal/drupal-admin-ui/9267?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
under the run-test pull down option
#!/bin/bash -eo pipefail docker exec -it drupal_admin_ui_drupal drush user:password admin admin REACT_APP_DRUPAL_BASE_URL=http://drupal NIGHTWATCH_LOGIN_admin_PASSWORD=admin yarn test ^@^@ [success] Changed password for admin. yarn run v1.16.0 $ yarn run test:lint && yarn workspace @drupal/admin-ui test $ eslint packages/*/src --ext .js,.jsx,.ts,.tsx --max-warnings=0 --format junit -o reports/eslint-junit.xml
The build scripts correctly identify the container as
drupal_admin_ui_drupal
whereas the README.md uses
drupal_admin_ui_node
The instructions have been revised -- and are in a excellent state of readability.
There is a error hidden in the README.md
looking at the "testing" subheading
the container name is incorrect throughout the command line instructions.
looking at a recent test run
https://circleci.com/gh/jsdrupal/drupal-admin-ui/9267?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
under the run-test pull down option
The build scripts correctly identify the container as
drupal_admin_ui_drupal
whereas the README.md uses
drupal_admin_ui_node