Open anevins12 opened 5 years ago
@anevins12 If you run yarn run eslint
locally it should fix the eslint problem automatically for you :) This should make the tests passing.
@anevins12 If you run
yarn run eslint
locally it should fix the eslint problem automatically for you :) This should make the tests passing.
I'm just wondering how you read the error log that indicated the linting issue. At the moment I'm finding it difficult identifying the errors from the failed pipelines.
Issue
The keyboard experience of the Drawer navigation takes more effort than it should to navigate it. When pressing the 'tab' key to navigate through the items in the Drawer, you have to press the tab key twice to reach other navigation items. This is because the list item of the Drawer itself has the functionality of a button. https://github.com/jsdrupal/drupal-admin-ui/issues/738
Screenshot / UI changes
The interaction events on hover, click and focus no longer apply to the
<li>
and so the UI looks the same as it does in its default state. However the outline of the focus indicator persists (yay).Testing instructions