jsdrupal / drupal-react-components

20 stars 0 forks source link

pagination #3

Closed mattgrill closed 6 years ago

dawehner commented 6 years ago

Fair :) I would focus on the variant we want to actually use in core for now :)

On Thu, 11 Jan 2018 at 16:04 Matthew Grill notifications@github.com wrote:

@mattgrill commented on this pull request.

In src/components/pager/index.js https://github.com/jsdrupal/drupal-react-components/pull/3#discussion_r160995200 :

@@ -0,0 +1,127 @@ +import React, { Component, Fragment } from 'react'; +import classNames from 'classnames'; +import { number, bool, func } from 'prop-types'; + +export default class Pager extends Component {

  • static propTypes = {
  • current: number.isRequired,
  • total: number.isRequired,

Humm, yep. That's probably a bit easier to implement. Maybe we can offer both versions.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/jsdrupal/drupal-react-components/pull/3#discussion_r160995200, or mute the thread https://github.com/notifications/unsubscribe-auth/AABz7rD29ixyNry0i_aBak-cA70pZu9Kks5tJjDKgaJpZM4RZ35f .