search

jseidl / hass-magic_areas

Areas with batteries included for Home Assistant
MIT License
273 stars 28 forks source link

Devcontainer environment and better coding practices #326

Closed jseidl closed 5 months ago

jseidl commented 6 months ago

This PR introduces the merge of integration_blueprint into this repo. A few things such as vscode devcontainer environment and configuration for black, flake8, pylint and isort.

A few workflows changed a few more to come whenever I'm able to start on tests.

I've ran the "autofixes' from ruff, black and isort but I still need to work on general docstring and code enhancements before it can pass ruff check which is the goal.

My stretch goal is to add typing with mypy

jseidl commented 6 months ago

After a lot of work to get the linters happy and tests to start rolling off, I broke some stuff but it's now (apparently) fixed.

I made a test to test that the area goes to on when a presence sensor is detected. I need to modify the test area config to have a short clear timeout so I can add the negative test.

jseidl commented 5 months ago

Closes #331 and #318