search

jseidl / hass-magic_areas

Areas with batteries included for Home Assistant
MIT License
254 stars 28 forks source link

Update climate.py #329

Closed pinkfish closed 3 months ago

pinkfish commented 4 months ago

Update the import to the correct path, this is causing errors in my home assistant, I assume something changed in the core code.

jseidl commented 3 months ago

Hi @pinkfish, thanks for the updates. I have a tons of breaking changes on a separate branch and I'll have to go through your changes and manually merge.

Since you've added a bunch of different changes to one pr, can you list the changes you did and their purpose?

Thanks

pinkfish commented 3 months ago

Oh, opps. Sorry, iot looks like it kept adding in my updates into this list of things to add in. I was only trying to add in the one change at the top. I always find github less than useful around merges. :(. I should revert this one. I did make a lot of changes to your code, but I changed some things quite dramatically too, so I doubt you would want to merge this. You might want to look at the test code I wrote, I see you did some tests but I have a more complete test for the config flow you might find helpful and some mock sensors I create and manipulate to test the various states and timeouts. You should just reject this change though.

jseidl commented 3 months ago

No worries! Yeah I do appreciate your contribution to the tests as I was just starting with it and finding my way trough, really really thanks!

Let me know what other changes you're working on, maybe some of them are useful for the community and I can pull it in. If you'd prefer to chat over DM, hop on our discord and we can chat.