search

jselbie / stunserver

Version 1.2. This is the source code to STUNTMAN - an open source STUN server and client code by john selbie. Compliant with the latest RFCs including 5389, 5769, and 5780. Also includes backwards compatibility for RFC 3489. Compiles on Linux, MacOS, BSD, Solaris, and Win32 with Cygwin. Windows binaries avaialble from www.stunprotocol.org.
http://www.stunprotocol.org
Apache License 2.0
1.41k stars 347 forks source link

Avoid using APIs deprecated in OpenSSL 3.0 #48

Open cgutman opened 1 year ago

cgutman commented 1 year ago

This PR fixes OpenSSL 3.0 API deprecation warnings (or errors, if OpenSSL 3.0 was compiled without deprecated APIs). Most of the API changes were trivial 1:1 replacements, but the EVP MAC API is a little more complex than the old HMAC API was.

In this change, I also reordered the __APPLE__ checks to avoid creating a mess of nested #ifs.

Verified teststuncode is passing with both OpenSSL 3.0 and OpenSSL 1.1.1.

jselbie commented 1 year ago

Good stuff. I will take a look at this PR this week. Preliminary review looks good. Thanks!

On Sun, Nov 27, 2022 at 8:19 PM Cameron Gutman @.***> wrote:

This PR fixes OpenSSL 3.0 API deprecation warnings (or errors, if OpenSSL 3.0 was compiled without deprecated APIs). Most of the API changes were trivial 1:1 replacements, but the EVP MAC API is a little more complex than the old HMAC API was.

In this change, I also reordered the APPLE checks to avoid creating a mess of nested #ifs.

Verified teststuncode is passing with both OpenSSL 3.0 and OpenSSL 1.1.1.

You can view, comment on, or merge this pull request online at:

https://github.com/jselbie/stunserver/pull/48 Commit Summary

File Changes

(2 files https://github.com/jselbie/stunserver/pull/48/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/jselbie/stunserver/pull/48, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHNSF3FR7H3GROMSPM45ODWKQXGLANCNFSM6AAAAAASM4XNLQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

muink commented 2 months ago

Is this PR ready for merging?