search

jsenv / importmap-node-module

Generate importmap for node_modules
35 stars 4 forks source link

Allow legacy package main fields #42

Closed dmail closed 3 years ago

dmail commented 3 years ago

The idea is to use "module" and "jsnext:main" when they exists but log a warning explaing that "exports" should be favored.

github-actions[bot] commented 3 years ago

Performance impact

Impact on 5 metrics when merging allow_legacy_package_main_fields into master. Before drawing conclusion, keep in mind performance variability.

@jsenv/importmap-node-module package
Metric Before merge After merge Impact
import duration 0.375 seconds 0.37 seconds -0.005 seconds / -1.33% :arrow_lower_right:
import memory heap used 16.51 MB 16.68 MB +169.45 KB / +1% :arrow_upper_right:
npm tarball size 77.73 KB 78.56 KB +847 B / +1.06% :arrow_upper_right:
npm tarball unpacked size 340.54 KB 344.51 KB +3.97 KB / +1.17% :arrow_upper_right:
npm tarball file count 26 26 :ghost:

Generated by @jsenv/performance-impact during performance_impact#1293847108 on 43c0d94

codecov[bot] commented 3 years ago

Codecov Report

Merging #42 (43c0d94) into master (72d9de6) will increase coverage by 0.97%. The diff coverage is 81.48%.