search

jseppi / Leaflet.MakiMarkers

Leaflet plugin to create map icons using Maki Icons from Mapbox.
MIT License
140 stars 39 forks source link

Any chance of an update? #19

Closed humblecoder closed 5 years ago

humblecoder commented 5 years ago

Any chance of an update? As of this post, Leaflet is on 1.4.0 and doesn't seem to properly load/initialize with this plugin.

jseppi commented 5 years ago

Hey @humblecoder - are you seeing an error of some sort?

I've updated the example index.html (see https://github.com/jseppi/Leaflet.MakiMarkers/commit/0e7e0431025571bbceca6308a9570e3bca189504) to use Leaflet 1.4.0 and changed the example basemap to one offered by carto.com since the previous MapQuest service is now gone.

Everything looks like it still works to me, and I didn't have to make any changes to Leaflet.MakiMarkers.js.

humblecoder commented 5 years ago

@jseppi Thanks. I'm using VueJS and including the plugin via imports which should have been just fine. I was getting errors of L being undefined. I shuffled the code a bit and all is well. Now, however, I'm having an issue with some of the icons. Apparently not all in the list are valid. Any links to updated icon names?

jseppi commented 5 years ago

I think the marker names given by https://github.com/mapbox/maki/blob/v0.5.0/_includes/maki.json should all be valid.

humblecoder commented 5 years ago

Thanks, those seem to work!