search

jserv / amacc

Small C Compiler generating ELF executable Arm architecture, supporting JIT execution
Other
1.01k stars 159 forks source link

Fix pointer arithmetic error by shift operation #25

Closed JohnnyLChang closed 7 years ago

JohnnyLChang commented 7 years ago

Fixes #21"

jserv commented 7 years ago

Rework commit message: Fixes #21" in order to close issue #21. is not effective. Instead, simply say "Fixes #21".

jserv commented 7 years ago

Please read How to Write a Git Commit Message carefully and rewrite the commit message.

JohnnyLChang commented 7 years ago

I appreciate your assistance.

jserv commented 7 years ago

Change the Git commit message again. You didn't fully apply the advised changes.

JohnnyLChang commented 7 years ago

got it, thanks

jserv commented 7 years ago

@JohnnyLChang , Thanks for your contribution. Please check the commit message for writing better one.

JohnnyLChang commented 7 years ago

I really appreciate for your information and I will review it. thanks.

2017-06-09 16:43 GMT+08:00 Jim Huang notifications@github.com:

@JohnnyLChang https://github.com/johnnylchang , Thanks for your contribution. Please check the commit message for writing better one.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jserv/amacc/pull/25#issuecomment-307331838, or mute the thread https://github.com/notifications/unsubscribe-auth/AE2s98JVUzBuLfDU-XoUleGZCR-Ovbg9ks5sCQWXgaJpZM4N0ZU1 .