search

jserv / full-stack-hello

minimal instruction set and assembler/compiler for "Hello World" execution
Other
114 stars 49 forks source link

fix warning #25

Closed pakls closed 7 years ago

pakls commented 7 years ago

@mlouielu How does this one look like?

mlouielu commented 7 years ago

The commit looks good to me, but the commit message needs to change more descriptive. The commit message needs to describe that it fix the compile warning, so "Fix compile warning" as title will be a better title.

About git commit message, you can see this for reference: https://blog.louie.lu/2017/03/21/如何寫一個-git-commit-message/

mlouielu commented 7 years ago

@pakls, just a nit point, for consistency, commit message first chracter should be capitalize.