search

jserv / full-stack-hello

minimal instruction set and assembler/compiler for "Hello World" execution
Other
114 stars 49 forks source link

Move insert halt at end to assemble_from_file #8

Closed mlouielu closed 7 years ago

jserv commented 7 years ago

What is the motivation?

mlouielu commented 7 years ago

since driver.c should allow to be replaceable, I think halt should auto insert into the end of the file.

Or maybe we could propose another approach, when dispatch to the end of the instruction, eval loop will break out without halt instuction.

jserv commented 7 years ago

@mlouielu, It is time to learn how CPython internals work and "cherry-pick" ideas to this project as testbed.

mlouielu commented 7 years ago

@jserv yep, I borrow some implement method from CPython.

mlouielu commented 7 years ago

Close this issue, propose #10 for better implement.